Remove legacy generated.yaml references and unused message template#511
Open
HishamHR5 wants to merge 2 commits intodevsecopsmaturitymodel:mainfrom
Open
Remove legacy generated.yaml references and unused message template#511HishamHR5 wants to merge 2 commits intodevsecopsmaturitymodel:mainfrom
HishamHR5 wants to merge 2 commits intodevsecopsmaturitymodel:mainfrom
Conversation
vbakke
reviewed
Mar 17, 2026
Collaborator
vbakke
left a comment
vbakke
left a comment
There was a problem hiding this comment.
This is actual deliberate code to handle backwards compatibility, if anyone has old model files.
However, with the new Settings page, it is now quite easy to get the latest model file, so I vote for removing this code, after all.
Meaning: I approve your merge request, @HishamHR5.
You just have to fix the linting error. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
-src/assets/YAML/meta.yaml — Removed commented reference to generated/generated.yaml
-src/app/component/modal-message/modal-message.component.ts — Removed generated_yaml error template
-src/app/service/loader/data-loader.service.ts — Removed legacy flag and conditional error suppression